Handle ListedColormaps in expand and cmap_and_norm - #241
Merged
Conversation
JamesVarndell
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #240 by checking whether
colorsis aListedColormapdirectly upon enteringcmap_and_normrather than after modification (extension). Now works when defining theStyleas follows, wherelevelsrepresents the right border of each level and there is an additional extension at the end. I'm assuming that's the intended behaviour but not sure.Testing without
style=shows no change in the default behaviour (as intended) but I'm not sure what other tests are useful here.Minimum working example, can probably be improved in terms of e.g. skipping parts of
cmap_and_normcompletely forListedColormaps.I think it would be good to add this to the documentation gallery somewhere but wasn't sure where. If you want to go really crazy you could add SPI and SPEI as built-in styles.
Contributor Declaration
By opening this pull request, I affirm the following: